search

iceberg-project / Penguins

MIT License
3 stars 3 forks source link

iceberg_penguins.detect runtime error #13

Closed bspitzbart closed 4 years ago

bspitzbart commented 4 years ago

(base) [bspitz@login005 Penguins]$ iceberg_penguins.detect Traceback (most recent call last): File "/home/bspitz/.local/bin/iceberg_penguins.detect", line 15, in from iceberg_penguins.search.models import create_model File "/home/bspitz/.local/lib/python3.5/site-packages/iceberg_penguins/search/models/init.py", line 2, in from models.base_model import BaseModel ImportError: No module named 'models'

bspitzbart commented 4 years ago

The package installs smoothly now, but I still get the error above. Is models not linked correctly? Is models/init.py correct?

iparask commented 4 years ago

Hello @bspitzbart, I think there are several issues along all the files of how it does imports.

The __init__.py you are referring is importing from base_model, which is in the same "path". It misses a . before base_model. Then, the base model imports from util which is a level up from models. It misses .. before util. An example is here.

If you want more information you can find it here. Also, lets allocate half an hour in this CI meeting to discuss imports in python

AymenFJA commented 4 years ago

This problem is solved with the latest release.