search

iceberg-project / Penguins

MIT License
3 stars 3 forks source link

Disable display visualizer. #14

Closed iparask closed 4 years ago

iparask commented 4 years ago

Remove the display check from the visualizer as HPCs do not offer displays.

AymenFJA commented 4 years ago

@iparask @bspitzbart Does removing the visualizer include removing all the associated imports, scripts, etc. as well? or just the package installation from the environment.yml and the README file?

bspitzbart commented 4 years ago

I think you will need to comment out the imports and script calls because they will fail if the package is not installed. I say comment out instead of remove so that future users can see that the visualizer is an option.

AymenFJA commented 4 years ago

Great, I will work on it now. Thanks @bspitzbart

iparask commented 4 years ago

ping @AymenFJA

AymenFJA commented 4 years ago

@iparask i need to discuss this further, during the CI meeting today.

AymenFJA commented 4 years ago

This ticket is solved.