search

iceberg-project / Penguins

MIT License
3 stars 3 forks source link

Meaningful commit messages #2

Closed iparask closed 5 years ago

iparask commented 5 years ago

Hello @lmhieu612, @bspitzbart,

I was checking the state of this use case. Despite pending issue #1, it is very difficult for me to follow the development phase for the Penguins use case due to the fact that many commit messages are just a couple of letters like cl and re. Furthermore, I see no Pull requests that explain the development and or what is committed.

Do you mind if from now on this repo also follows the Development guide of the project as close as possible?

Thank you, Giannis

hieulem commented 5 years ago

Hi @iparask,

This repo is under development. Except for the last two commit messages, which was not related to the developing features (they are for cleaning and re-organizing the repo), the others are quite meaningful.

I will make sure the repo follow the Development guide from now on.

iparask commented 5 years ago

The repo does not follow the development guidelines of the project. All repos are under development. Can we start bringing the repo in sync?

bspitzbart commented 5 years ago

We created a devel branch with the appropriate structure. Hieu will be pushing in code.

iparask commented 5 years ago

Thank you! Although I am not sure why it was not branched off master? I will be easier to merge after.

bspitzbart commented 5 years ago

Right. Fixed. It is now branched off master.

iparask commented 5 years ago

But everything is deleted! Is the code from master useful or not?

I would suggest that the devel branch is a reorganization of the master branch. It can be done in steps. It does no need to happen in one go.

bspitzbart commented 5 years ago

Hieu will add the useful code from master (in a different branch, of course). That is how we did Seals.