search

iceberg-project / Seals

This repo will be used for ICEBERG-related science: scripts, models, figures, and findings related to ICEBERG and its Seal detection use case.
MIT License
7 stars 3 forks source link

Fix/kernels 34 #41

Closed bspitzbart closed 5 years ago

bspitzbart commented 5 years ago

This pull request addresses issue #34 and milestone block. predict_raster_det.py is the kernel for predictions tile_raster.py is the kernel for tiling (no changes)

Bento - are there other issues fixed with my import of the code from https://github.com/bentocg/seals_temp/blob/master/predict_raster_det.py?

bentocg commented 5 years ago

That will work. I can also add the shapefile output to predict_patch, I think that's what @iparask would prefer in the first place.

iparask commented 5 years ago

Hello @bentocg, I think that is what is needed as the ouput, right? Can you please do that and submit a new PR? I want to test the final script as soon as possible to catch the milestone.

bentocg commented 5 years ago

It needs some testing, but I think it has the correct output now. I'll push to the temp repo and maybe Brad and I can test it.

Em seg, 10 de dez de 2018 às 17:08, Ioannis Paraskevakos < notifications@github.com> escreveu:

@iparask approved this pull request.

I am okay with this PR. if @bentocg https://github.com/bentocg is also fine let's merge and I will try to test the entk script with these changes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iceberg-project/Seals/pull/41#pullrequestreview-183349607, or mute the thread https://github.com/notifications/unsubscribe-auth/AID5WB0K20YJsOlvzxGqzZTFQVtHDMFkks5u3rEdgaJpZM4ZE_p6 .

iparask commented 5 years ago

There is no need to use the temp branch. Branch off devel and test there. It will end up in devel in the end. It will also help avoid conflicts.