icecats11 / js-hotkeys

Automatically exported from code.google.com/p/js-hotkeys
0 stars 0 forks source link

DisableInInput Should also disable keys in SELECT tags #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Setup DisableInInput to true
2. Set cursor focus to an html select element
3. Press a configured keyboard shortcut

What is the expected output? What do you see instead?
I would hope that focus on select elements would disable keyboard shortcuts
if DisableInInput is true.  
Currently, the keyboard shortcut is executed.

What version of the product are you using? On what operating system?
Using commit 8275c7355b9dfda5f6cf1a7f4eba3ab358700bcb (current as of today)
from github repo.
Running Ubuntu 8.10 with Firefox 3.0.6

Please provide any additional information below.
The reasoning for this is many times keyboard users use the keyboard to
choose items in select lists (I for one) in order to speed up data entry.
Sometimes those keyboard entries to choose items in select elements can
conflict with the keyboard shortcuts configured. 

I have attached a patch the implements this change and it works for me.

I am submitting it for your approval and possible inclusion.

Best Regards,

Paul Eden

Original issue reported on code.google.com by benchl...@gmail.com on 26 Feb 2009 at 8:15

Attachments:

GoogleCodeExporter commented 8 years ago
will be available in the next release

Original comment by Afro.Sys...@gmail.com on 3 May 2009 at 7:24