icecave / collections

A PHP collection library loosely inspired by the .NET runtime and the C++ STL. [DEPRECATED]
MIT License
70 stars 2 forks source link

Rename ambiguous methods with immutable and mutable variants #46

Closed jmalloc closed 11 years ago

jmalloc commented 11 years ago
filter / filtered --> filter / copyAndFilter
sort / sorted --> sort / copyAndSort
merge / combine --> merge / copyAndMerge
append / join --> append / copyAndAppend
apply / map --> map / copyAndMap

There is no mutable version of AssociativeInterface::project ?

jmalloc commented 11 years ago

@ezzatron trying to get some more consistent naming going here, thoughts?

ezzatron commented 11 years ago

I'd probably prefer past-tense, but apart from that they look okay.

jmalloc commented 11 years ago
jmalloc commented 11 years ago

I hate 'copyAnd' now :(

ezzatron commented 11 years ago

Copìand will not stand for this injustice.

jmalloc commented 11 years ago

Ok, let's try again.

So, the only shit one now is "appendInPlace". HALP.

jmalloc commented 11 years ago

Reverted join/append to original names.