search

icecc / icecream

Distributed compiler with a central scheduler to share build load
GNU General Public License v2.0
1.58k stars 250 forks source link

daemon: fix `MemTotal` on macos #467

Closed timblechmann closed 5 years ago

timblechmann commented 5 years ago

the mach codepath doesn't obtain MemTotal, which will always cause the a pessimistic 100MB memory limit. as later on, we'll just return 0.

the best way on macos to obtain the total memory is reading hw.memsize

timblechmann commented 5 years ago

compare: #466

zbeekman commented 5 years ago

Can someone ping me when/if this is merged? I'd like to backport this patch to the homebrew formula.

HenryMiller1 commented 5 years ago

@zbeekman merged.

timblechmann commented 5 years ago

@HenryMiller1 thanks for merging it so quickly!