icecc / icecream

Distributed compiler with a central scheduler to share build load
GNU General Public License v2.0
1.58k stars 250 forks source link

Use pkg-config to find packages #534

Closed JPEWdev closed 4 years ago

JPEWdev commented 4 years ago

Package config should be used to find packages instead of manually searching for headers. This makes cross-compiling easier, as well as makes it possible to build a static binary (in particular, libarchive is annoying to link statically without using pkg-config)

llunak commented 4 years ago

Looks ok to me in general, but the Cirrus check fails, do you have any idea why? It built fine without your change.

JPEWdev commented 4 years ago

Looks ok to me in general, but the Cirrus check fails, do you have any idea why? It built fine without your change.

It looks like pkg-config can't find libarchive.pc.... I don't really know a lot about FreeBSD, but it appears that it can't find it for some reason. I'll going to try and boot a freebsd QEMU image to see if I can replicate it

JPEWdev commented 4 years ago

Looks ok to me in general, but the Cirrus check fails, do you have any idea why? It built fine without your change.

libarchive was missing from the package list

llunak commented 4 years ago

Thank you.