search

icecc / icecream

Distributed compiler with a central scheduler to share build load
GNU General Public License v2.0
1.58k stars 248 forks source link

Revert "Refactor Msg class" #626

Open stefanu21 opened 10 months ago

stefanu21 commented 10 months ago

This reverts commit c0f9d537bd47e3326e1126444267cf43bd59696f.

This is a break in the api. Projects like icemon no longer works.

ossilator commented 10 months ago

this feels very wrong to me. instead, the internal api should be properly versioned, and icemon (the only external consumer?) should have the required #ifdefs.

stefanu21 commented 10 months ago

yes you are right but the mistake has already happened that the api is not versioned correctly. nevertheless there is no compelling reason to change the api like this and make the clients unusable. after all, this is just cosmetics. if it would be about projects that would be developed much further ok but neither icecc nor icemon has done anything substantial in the last years except the new scheduler modis...