search

icecc / icemon

Icecream GUI Monitor
http://kfunk.org/tag/icemon/
GNU General Public License v2.0
88 stars 34 forks source link

RFC: use ECM #44

Closed pinotree closed 5 years ago

pinotree commented 5 years ago

Start using extra-cmake-modules at build time, so it is possible to simplify some of the cmake code using its facilities.

The only used module so far is ECMInstallIcons, which replaces an old module.

HenryMiller1 commented 5 years ago

This needs to build on the ci system. Shouldn't be a hard change, I guessing there is a module that just needs to be installed.

pinotree commented 5 years ago

Unfortunately, there is no extra-cmake-modules on Ubuntu 14.04 (which is the OS specified in the travis configuration)...

HenryMiller1 commented 5 years ago

Icecc now requires 16.04, (or will soon, I might not have accepted the pull request yet), so I upgrading here makes sense. Or you can download and install the release, ecm doesn't really need to come from a package.

Henry Miller hank@millerfarm.com

On Sat, Dec 22, 2018, at 8:29 AM, Pino Toscano wrote:

Unfortunately, there is no extra-cmake-modules on Ubuntu 14.04 (which is the OS specified in the travis configuration)...> — You are receiving this because you commented. Reply to this email directly, view it on GitHub[1], or mute the thread[2]. Links:

  1. https://github.com/icecc/icemon/pull/44#issuecomment-449574350
  2. https://github.com/notifications/unsubscribe-auth/AI8oEgLMeY0QDgzkr1RSKOkiqedEtJXVks5u7kHjgaJpZM4ZfaOZ
pinotree commented 5 years ago

Bumping the distro in travis to xenial seems to have solved the CI issue. ECM is just a build-only dependency, so it should be easy for people with distros without it to just build it on their own.