Buildsystem fixes - Githubissues

icecc / icemon

Icecream GUI Monitor

http://kfunk.org/tag/icemon/

GNU General Public License v2.0

90 stars 34 forks source link

Buildsystem fixes #5

Closed pinotree closed 11 years ago

pinotree commented 11 years ago

This series of commits provides

cleanups of the cmake stuff
small improvements
installation of the application icon (referenced by the .desktop file) using macros copied by kdelibs

While the usage of the kdelibs macro is certainly not mandatory, it simplifies and automates a bit the actual cmake stuff required to install the icons. Also, the minimum CMake required is now 2.8.5 (which has been released ~2 years ago, 2011-07-08), I hope it is not too high.

krf commented 11 years ago

Why is the bump to CMake 2.8.5 actually required? Other than that the patch looks fine and it can be merged.

pinotree commented 11 years ago

As I also wrote in the commit message, GNUInstallDirs is new in cmake 2.8.5.