search

iceclementi / pe

0 stars 0 forks source link

Entering a future date for date of bith #2

Open iceclementi opened 4 years ago

iceclementi commented 4 years ago

It is possible to enter a future date for the date of birth of a person. Should this be restricted to a past date?

image.png

nus-pe-bot commented 4 years ago

Team's Response

Rejected for the following reasons:

  1. We don't want to stop users from using this product in the future.
  2. The users should be responsible for the correctness of the flashcard contents they enter.
  3. Science fiction 'history' can be in the future. Users may intentionally want to enter fictional birth dates, and we do not wish to over-restrict user inputs.

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do not fully agree with the 3 points you have raised.

  1. This does not stop users from using your product in the future. I guess you may be thinking of perhaps using a MAGIC NUMBER for the upper bound of the date. However, you can simply use Java's LocalDate.now() method to get the current date of your device. Then use that as the upper bound of the user's inputted date.

  2. This may be true but should be properly facilitated as well. There should be at least be a prompt to inform the user that their input , in this case the date, may be wrong. Also your current implementation of the product makes it difficult to correct the content of the created flashcard since there is no edit features at all. The user has to delete, and then recreate the card.

  3. This was clearly not specified anywhere in both the UG and DG. In fact, the UG claims that "History Flashcard (HF) is for those who are studying history subjects to create flashcards which summarize the most important information for historical events, figures and artifacts.", and the normal assumption for the reader is that this refers to non-fictional events of the past. Not assuming anything, but if the product's aim was to include studying science fiction as well, then it should have stated it in a much clearer way.