Closed apizzuto closed 3 years ago
From what I've heard, having well-implemented tests makes JOSS review a lot easier. Here are some tests for Firesong.py, and they moved all of the test scripts to a dedicated directory (https://github.com/icecube/FIRESONG/issues/26)
Also tracked these changes through to the README (https://github.com/icecube/FIRESONG/issues/16)
Small commit as well that fixes a deprecation warning from numpy (replacing np.asscalar(result) with result.item())
From what I've heard, having well-implemented tests makes JOSS review a lot easier. Here are some tests for Firesong.py, and they moved all of the test scripts to a dedicated directory (https://github.com/icecube/FIRESONG/issues/26)
Also tracked these changes through to the README (https://github.com/icecube/FIRESONG/issues/16)
Small commit as well that fixes a deprecation warning from numpy (replacing np.asscalar(result) with result.item())