Hi all, since the use of cosmolopy introduces too much uncertainties, I want to ditch it.
In this version, FIRESONG no longer relies on cosmolopy, and the cosmology calculations are handled by a class cosmo_distance in firesong/distance.py
The changes to the result is minimal, only observed in test_evolution.py in the following 3 tests
standard candle flux --> 9.244753729666578e-11 vs 9.244753729666597e-11
Nsources --> 3745.1796382799967 vs 3745.179638278482
transient redshift distribution --> difference at 4 decimal place
Please let me know what you think about moving this forward.
Hi all, since the use of cosmolopy introduces too much uncertainties, I want to ditch it. In this version, FIRESONG no longer relies on cosmolopy, and the cosmology calculations are handled by a class
cosmo_distanceinfiresong/distance.pyThe changes to the result is minimal, only observed in test_evolution.py in the following 3 tests
standard candle flux --> 9.244753729666578e-11 vs 9.244753729666597e-11 Nsources --> 3745.1796382799967 vs 3745.179638278482 transient redshift distribution --> difference at 4 decimal place
Please let me know what you think about moving this forward.