removed zmin from Firesong, FluxPDF, and Legend -- #59
zmin are not supposed to be adjusted by users in the current implementation, because the integral in the source population is carried out from 0 to zmax. Sample redshift from zmin will break the assumption.
removed Results in outputdir -- #63
The current way of setting environment variable FIRESONG is unclear. It is said to be the user defined directory for output, but it's actually outputting to $FIRESONG/Results. I removed the requirement for the Results folder
adjusted README for clarity -- #62
Example will print the . in front of Firesong.out. Also tell users to define the environment variable FIRESONG, but the command line example should work even without setting the variable, because the requirement of the Results folder is removed.
removed
zminfrom Firesong, FluxPDF, and Legend -- #59zminare not supposed to be adjusted by users in the current implementation, because the integral in the source population is carried out from 0 tozmax. Sample redshift fromzminwill break the assumption.removed
Resultsin outputdir -- #63 The current way of setting environment variableFIRESONGis unclear. It is said to be the user defined directory for output, but it's actually outputting to$FIRESONG/Results. I removed the requirement for theResultsfolderadjusted README for clarity -- #62 Example will print the
.in front ofFiresong.out. Also tell users to define the environment variableFIRESONG, but the command line example should work even without setting the variable, because the requirement of theResultsfolder is removed.added ra to output for Firesong and Legend in response to [https://github.com/openjournals/joss-reviews/issues/3194#issuecomment-830461894]
added notebook for legend same as pt 3