search

icecube / FIRESONG

FIRst Extragalactic Simulation Of Neutrino and Gamma-ray
Other
18 stars 8 forks source link

allow to parameterize luminosity functions in "natural parameters" instead of mean_luminosity #70

Closed HansN87 closed 2 years ago

HansN87 commented 2 years ago

The mean_luminosity is not a good property to characterize powerlaws or broken powerlaws. A more natural choice would be Lmin, Lmax, gamma (or Lmin, Lmax, Lbreak, gamma1, gamma2).

The current design puts a lot of emphasis on the mean_luminosity https://github.com/icecube/FIRESONG/blob/9955d4c6e3d3f55898169cf456536133a16d30f2/firesong/Luminosity.py#L232 and performs the transformation to the natural parameters implicitly e.g. here (powerlaw) https://github.com/icecube/FIRESONG/blob/9955d4c6e3d3f55898169cf456536133a16d30f2/firesong/Luminosity.py#L182

Suggest to rework the interface to the underlying PDFs such that the user can specify the natural parameters directly.