search

icecube / flarestack

Unbinned likelihood analysis code for astroparticle physics datasets
https://flarestack.readthedocs.io/en/latest/?badge=latest
MIT License
8 stars 7 forks source link

Support python 3.11 in CI #261

Closed mlincett closed 1 year ago

mlincett commented 1 year ago

We should add python 3.11 in CI.

Currently there may be some problems (see https://github.com/python-poetry/poetry/issues/7686) due to poetry being picky about invalid wheel files.

Also we should decide how many versions of python we should keep testing against.

mlincett commented 1 year ago

Draft PR #262 has been opened to track this.

mlincett commented 1 year ago

Issue at debugpy: https://github.com/microsoft/debugpy/issues/1246

robertdstein commented 1 year ago

I'm not sure what the best thing here is. We could edit the CI to do the "modern installer = False" option, or pin poetry 1.4.0. I have the impression that poetry will not "fix this" in future versions, since they view it as a check and the upstream repos like debugpy are the source of the problem because their wheels aren't correctly generated.

On the python versions point, I would think it makes sense to test all the ones we currently do, since that costs nothing, but to not commit to maintaining compatibility. As soon as we have a good reason to drop an old version, e.g new-style code incompatible with e.g python 3.8, then we should just drop that version.

mlincett commented 1 year ago

Thanks for the feedback @robertdstein . I was honestly thinking of sitting on this for a reasonable amount of time to see whether the situation can be resolved upstream without us having to implement and follow-up workarounds. It seems Microsoft is aware there's an issue, they just mentioned it's high priority.

mlincett commented 1 year ago

Seems the issues are fixed upstream, so I am merging the pending PR now.

Will add 3.12 as soon as setup-python will support it.