Rename scratch directory and data directory

icecube / flarestack

Unbinned likelihood analysis code for astroparticle physics datasets

https://flarestack.readthedocs.io/en/latest/?badge=latest

MIT License

8 stars 7 forks source link

Rename scratch directory and data directory #293

Open mlincett opened 1 year ago

mlincett commented 1 year ago

Following up on #292 I would propose to rename the following:

flarestack__data to flarestack_cache or flarestack_workdir; so there is no confusion with FLARESTACK_DATASET_DIR.
FLARESTACK_SCRATCH_DIR to SCRATCH_DIR, so it is clear that SCRATCH_DIR can be shared since a dedicated directory will be created inside.

JannisNe commented 1 year ago

I like it. It is a breaking change and I would suggest including a version bump to a new subversion already in the PR so that we can create a tag and a new release right away after merging. I guess #292 will come afterward and as such will be a bump to another patch.

robertdstein commented 1 year ago

I agree it's a good idea and just bump to v3