search

icecube / flarestack

Unbinned likelihood analysis code for astroparticle physics datasets
https://flarestack.readthedocs.io/en/latest/?badge=latest
MIT License
8 stars 7 forks source link

Proposal to deprecate python 3.8 #301

Closed mlincett closed 1 year ago

mlincett commented 1 year ago

Python 3.8 does not support the use of native tuple and list for type annotations.

Maintaining support python 3.8 means carrying around from typing import List, Tuple statements.

Something against discontinuing support for 3.8, @JannisNe , @robertdstein ?

robertdstein commented 1 year ago

Go for it! I think it's a great idea.

JannisNe commented 1 year ago

Nothing against dropping 3.8!

mlincett commented 1 year ago

I am trying to make this effective in #302 although it seems I cannot get rid of the CI test for 3.8, even after modifying the workflows file. Maybe I'll have to look deeper.

robertdstein commented 1 year ago

This will be fixed by #302