icecube / flarestack

Unbinned likelihood analysis code for astroparticle physics datasets
https://flarestack.readthedocs.io/en/latest/?badge=latest
MIT License
8 stars 7 forks source link

Appropriate configuration when applying pull correction #389

Closed sathanas31 closed 3 weeks ago

sathanas31 commented 1 month ago

"Fix" to #363:

In case of power_law epdf, if you choose static floors and pull correctors (eg median_1d) you need to provide the gamma in order to weight the MC, so basically these are applicable for fixed-gamma power law. Hence, raise an error if gamma is not provided in the llh_energy_pdf for these cases.

Other changes:

JannisNe commented 3 weeks ago

maybe change the name to something more descriptive, like appropriate warnings for KDEs with pull-corrections