search

icecube / i3mla

Public IceCube point-source analysis tools
Apache License 2.0
2 stars 1 forks source link

Threeml refactor #81

Closed jasonfan1997 closed 2 years ago

jasonfan1997 commented 2 years ago

Should be ready to merge

jasonfan1997 commented 2 years ago

Hi @thejevans you mentioned you are working on the comment of this branch?

thejevans commented 2 years ago

Hi @thejevans you mentioned you are working on the comment of this branch?

The comments should be there now

jasonfan1997 commented 2 years ago

I will try to make all the changes this week and we can merge it then. @mjlarson I think we should start discussing getting the collaboration review on the code(aiming before summer), what are the steps we need to go through? @thejevans as the main i3mla is settled, maybe you can work on some example notebooks like point source sensitivity and discovery potential? I will work on the 3ML example once I finish the i3mla side and update the 3ML plugin. There are several things we can also do, including cross-year data samples support, parabola interpolation, and stacking support(kind of difficult).

thejevans commented 2 years ago

there is one last question of should we switch to a class to manage events instead of directly using the raw numpy arrays. I spoke with @mjlarson about this last week. I think that the benefits outweigh the costs and help to future-proof the package.

I'm currently adding stacking support and txs like analysis support now.

jasonfan1997 commented 2 years ago

Ready for next review