icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 50 forks source link

Stage/service to define different binning for analysis #108

Open jllanfranchi opened 8 years ago

jllanfranchi commented 8 years ago

Additional stage that allows the user to define analysis binning that is possibly different than reco binning and possibly different binnings for each PID category.

Discussion from PISA call on 2016-08-24 (https://wikispaces.psu.edu/display/PINGU/PISA+-+PINGU+Simulation+Analysis):

Ste: can we have different binning for tracks and cascades...?

jllanfranchi commented 7 years ago

should be fixed in PISA pi...

LeanderFischer commented 7 months ago

So this here is actually an issue that we might consider implementing. @anilak41 et al have found workarounds to use different binnings, but this would be an amazing feature to pisa.

JanWeldert commented 2 months ago

A current hack is to use the detectors class to define different "detectors", one per PID bin (to use the example from before), and choose different energy and coszen binning for each of them. Note that for each detector you have to remove all events that don't fall in the respective PID bin.

thehrh commented 1 week ago

Adding to this thread, PR #835 by @marialiubarska is now proposing to introduce a VarMultiDimBinning class. Internally, it is represented by a tuple of (also new) EventSpecies objects, each of which has its own MultiDimBinning (among others). The Map and Container classes have been adapted, as well as the utils.hist service and the utils.config_parser module. Anyone feel free to take a look and review.