search

icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 49 forks source link

Analysis fix #671

Closed mvprado0 closed 3 years ago

mvprado0 commented 3 years ago

Fixed non-list metrics issue and included functions in stats.py to better condense some lines of code.

philippeller commented 3 years ago

Hi, could you comment how the bound guard is now needed after @atrettin bumped the scipy version which fixed the boundary issue?

mvprado0 commented 3 years ago

Hmm that's odd. I actually didn't do anything with the bound guard. I only implemented a couple of functions found in stats.py that are completely separate and fixed the issue that arises if the user inputs a metric that is not a list. I see the part about the bound guard that you're talking about but I'm confused why that changed. Maybe I somehow forked an older version of analysis.py? I didn't think I did...

mvprado0 commented 3 years ago

I just rechecked and I only changed the things until line 1184. Anything after that with the bound guard I didn't touch. It might be that I mistakenly corrected an older version of the code and not the latest one. I can fix that.

mvprado0 commented 3 years ago

Ok, all fixed. I reincorporated my new changes to Alex's guard bounds commit.

philippeller commented 3 years ago

Cool, was probably some merge mismatch before. Looking good now and I'll merge your PR!