search

icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

Make CRS2 fits reproducible #698

Closed atrettin closed 2 years ago

atrettin commented 2 years ago

This PR makes fits with CRS2 (or any other NLOPT algorithm with a random component) reproducible if a seed is passed to method_kwargs, and adds a unit test to assert that this behaves correctly. It also adds unit tests to fluctuate Map and MapSet objects and fixes an issue where get_random_state without a random state would crash.

philippeller commented 2 years ago

thanks for the fixes and improvements!