search

icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

fix resetting parameter values for 2. octant fit #710

Closed ellohfin closed 1 year ago

ellohfin commented 1 year ago

In octant fitting, if parameter values are not reset free between the single fits, the intended behavior is that after fitting the first octant, the parameter values (except for theta_23) are reset to where the first fit started. Due to the missing deepcopy, instead, they were set to the end point of the first fit instead.

philippeller commented 1 year ago

@ellohfin and @atrettin Is this good to merge?

atrettin commented 1 year ago

Got the OK from Elisa that all is good, so I merged.

philippeller commented 1 year ago

great, thank you both!