icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

Adding Covariance Matrices #715

Closed BenSmithers closed 1 year ago

BenSmithers commented 1 year ago

Basic functionality is here - hoping to continue work on this on a branch in the IceCube PISA repo rather than my personal fork.

What's here, now

What's not yet fully there

BenSmithers commented 1 year ago

The last two commits addressed a few bugs that I came across while using these in some fits. DerivedParams are a bit closer to serializability now

philippeller commented 1 year ago

This looks great! So the old parameters still are usable from within each stage as if nothing happened, but internally they are represented in the rotated form, if I understood correctly?

BenSmithers commented 1 year ago

This looks great! So the old parameters still are usable from within each stage as if nothing happened, but internally they are represented in the rotated form, if I understood correctly?

That's right! It essentially turns the two Params into four. The original ones are replaced with DerivedParams whose values are functions of the new, rotated, ones.

philippeller commented 1 year ago

Cool! Is this PR thought as WIP, or do you want to get what you have merged?

BenSmithers commented 1 year ago

I'd like what I have here merged!

philippeller commented 1 year ago

cool! I then only want to run a few checks and if they pass merge it

philippeller commented 1 year ago

Run come additional checks, it all looks good and will merge now