search

icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

Fix 3d map plotting - saving and return values. #726

Closed LeanderFischer closed 1 year ago

LeanderFischer commented 1 year ago

Fixed plot saving functionality for 3D maps and correct return types. Also added default dpi value and related argument. Started listing/implementing unit test for plot function, but not sure how necessary this is?!

philippeller commented 1 year ago

cool, very much appreciated! Happy to merge this, or is it still work in progress?

LeanderFischer commented 1 year ago

cool, very much appreciated! Happy to merge this, or is it still work in progress?

Only the (commented) part in the test_Map function is unfinished. I could remove those or actually implement some basic tests (if wanted?), but I don't see myself finding time before the collaboration meeting, unfortunately.

philippeller commented 1 year ago

There is a conflict that prevents me from merging. @LeanderFischer could you fix that one and then we'll merge