search

icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
18 stars 47 forks source link

Add HNL custom effective area stage - working state. #727

Closed LeanderFischer closed 1 year ago

LeanderFischer commented 1 year ago

Add custom effective area stage for OscNext HNL analysis. Can be used to re-weight single mass HNL sets for any mixing.

Uses constants (lightspeed, planck), can they be pulled from somewhere in PISA?

philippeller commented 1 year ago

Hey! In its current form, this stage duplicates the aeff stage and adds one more scaling. Could instead this not simply be a separate stage that only does the HNL reweighting and is added after the usual aeff stage?

I would for maintainability really like to avoid code duplication. If we will introduce changes to aeff in the future, we'd need to make these in two separate places given this PR.

LeanderFischer commented 1 year ago

Very true, will implement as such and get back to you.

LeanderFischer commented 1 year ago

How about this @philippeller?

philippeller commented 1 year ago

Yep, I think like this it's very clean and modular! Will merge now