icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

Implement Neutrino decay in PISA (Prob3) #748

Closed anilak41 closed 1 year ago

anilak41 commented 1 year ago

Modify numba_osc_kernels.py

Modify numba_hostfunctions.py

Modify prob3.py

New - decay_params.py

LeanderFischer commented 1 year ago

Please pull the master branch again and resolve the conflicts.

anilak41 commented 1 year ago

I have resolved the issues, and the numba_osc unit test is running fine on single and double precision on the local machine.

The modification of the numba_osc unit test has resulted in some new ref pkl files and these ref pkl files are not being recognized by Python 3.7 during the above check on git which resulted in the failure of the test and aborted the test for python 3.10 also.

Note that the double precision test on Python 3.10 was successful and it was checking for Python 3.7 when the test was aborted.

How can this issue be solved?

anilak41 commented 1 year ago

The PISA installation dependencies show that at least Python 3.8 is needed, then why are we still checking these tests for Python 3.7?

JanWeldert commented 1 year ago

Looks ok to me. Have you checked if you get the same osc probabilities with your code setting neutrino decay to 0 and the old code?

anilak41 commented 1 year ago

Yes.

Please see the plots in the attached presentation.

Neutrino_decay_PISA_Benchmarking.pdf

JanWeldert commented 1 year ago

Alright, should be good to go then.