Minor corrections to the external osc stage

icecube / pisa

Monte Carlo-based data analysis

http://icecube.github.io/pisa/

Apache License 2.0

18 stars 47 forks source link

Minor corrections to the external osc stage #759

Closed kotania closed 5 months ago

kotania commented 6 months ago

This pull request features one bug fix and one feature addition.

Bug fix: boolean flag for antineutrinos was not set correctly depending on the container['nubar'] output.
Feature addition: computation of neutron-weighted densities relevant for e.g. neutral current potential calculations.

LeanderFischer commented 6 months ago

Is there a reason this is a separate PR from #756?

kotania commented 6 months ago

Is there a reason this is a separate PR from #756?

This is merging commits to the peller/external branch from my local fork; the earlier pull request (756) wanted to merge peller/external branch into master. Perhaps they could be combined.

LeanderFischer commented 6 months ago

Is there a reason this is a separate PR from #756?

This is merging commits to the peller/external branch from my local fork; the earlier pull request (756) wanted to merge peller/external branch into master. Perhaps they could be combined.

Ah I see, my bad. Ok, so this will be automatically added to the other PR, once it's merged. It looks ok to me, but maybe Philip should better take a look himself.