search

icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
18 stars 47 forks source link

adding DAEMONFLUX stage #761

Closed marialiubarska closed 5 months ago

marialiubarska commented 5 months ago

I think it's finnaly time to merge this into master... Summary: I added daemonflux stage and a simple example notebook + cfg file (see https://arxiv.org/abs/2303.00022). Also updated flux readme as well as INSTALL.md to mention that daemonflux is now a dependency for this stage.

LeanderFischer commented 5 months ago

Looks good to me, but I didn't check the details of the stage itself. The discrepancies that @anilak41 is seeing are confirmed with this stage and with the pure python daemonflux, right? So I assume this is unrelated to the implementation of the stage?

And apart from the notebook there is no more detailed explanations than the paper itself?

anilak41 commented 5 months ago

I have used this daemon flux stage and checked the DAEMON flux, which looks consistent with the one obtained using daemonflux python library.