Closed ggarg07 closed 7 months ago
Did someone actually check this? 59 files changes is a whole lot?
Hi Leander, Krishnamoorthi had asked review from me. I went through their changes and approved them.
Hi Leander, Krishnamoorthi had asked review from me. I went through their changes and approved them.
Ok, that's good, apart from you merging, there was no sign of an actual review. Maybe next time when you go through the changes, especially if it is this many, write a comment that you looked at them and/or what you noticed etc., so that it's documented. For small changes, this isn't super important, but for big ones, it becomes easier to trace back what happened. Thanks!
Sure.
Long Range Potential Analysis
Introduced lriparams.py
LRIParams()
classModified prob3.py
lri_type
v_lri
parameterpropagate_array()
to includelri_pot
matrixModified numba_osc_kernels.py
osc_probs_layers_kernel()
to includelri_pot
matrixget_transition_matrix()
, addition oflri_pot
with the matter hamiltonianModified numba_hostfunctions.py
propagate_array()
propagate_scalar()
get_transition_matrix_hostfunc()
get_transition_matrix()
Modified numba_osc_tests.py