icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

Addition of LRI potential #762

Closed ggarg07 closed 7 months ago

ggarg07 commented 8 months ago

Long Range Potential Analysis

Modified prob3.py

Modified numba_osc_kernels.py

Modified numba_hostfunctions.py

Modified numba_osc_tests.py

LeanderFischer commented 7 months ago

Did someone actually check this? 59 files changes is a whole lot?

sc458930 commented 7 months ago

Hi Leander, Krishnamoorthi had asked review from me. I went through their changes and approved them.

LeanderFischer commented 7 months ago

Hi Leander, Krishnamoorthi had asked review from me. I went through their changes and approved them.

Ok, that's good, apart from you merging, there was no sign of an actual review. Maybe next time when you go through the changes, especially if it is this many, write a comment that you looked at them and/or what you noticed etc., so that it's documented. For small changes, this isn't super important, but for big ones, it becomes easier to trace back what happened. Thanks!

sc458930 commented 7 months ago

Sure.