Add warning when attempting to use the analytical NSI matrix

icecube / pisa

Monte Carlo-based data analysis

http://icecube.github.io/pisa/

Apache License 2.0

19 stars 47 forks source link

Add warning when attempting to use the analytical NSI matrix #775

Closed finnmayhew closed 4 months ago

finnmayhew commented 4 months ago

According to an existing comment (L390 of the edited file), the analytical version of the NSI matrix is not implemented correctly. Since this function is called in the PISA tests that run on changes to be merged, I'm writing a warning here rather than an error.

JanWeldert commented 4 months ago

Isn't there already a warning like this?

[ WARNING] Warning: the analytical NSI matrix is not yet properly implemented. Instead, use the numerical NSI matrix.
[ WARNING] Evaluating analytical expressions for NSI matrix elements does not give agreement with numerical calculation! Elementwise agreement:
[[ True False  True]
 [False  True False]
 [ True False  True]]
This is expected. Going ahead with numerical calculation for now

finnmayhew commented 4 months ago

Looks like it, cancelling my pull request!