search

icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 49 forks source link

Raise an exeption if the (not entirely implemented) analytical versio… #777

Closed finnmayhew closed 3 months ago

finnmayhew commented 3 months ago

…n of the effective NSI coupling matrix is accessed

finnmayhew commented 3 months ago

Hm, running this function should probably not be in the unit tests since it's not implemented.

LeanderFischer commented 3 months ago

Hm, running this function should probably not be in the unit tests since it's not implemented.

Yeah, totally, but even a step before, why is this function (body) even there, if it's apparently not implemented? I suggest do get rid of it altogether, if there is no value in keeping the body and/or the function at all, no?

Edit: Ah ok, this is in the process of being implemented? I suggest do leave incomplete code out of the master branch, work on it in a fork/branch until it is ready, and then get it in. Feel free to leave the empty function head and the NotImplementedError, but then take it out of the test of course :pray:

LeanderFischer commented 3 months ago

Solved through #786