icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

Useless/misleading stage instance debug_mode attribute? #782

Open thehrh opened 1 month ago

thehrh commented 1 month ago

This attribute claims to disable caching at the Stage base class level, but it doesn't actually seem to have any functionality. No service throughout the code base implements any custom behaviour. debug_mode was introduced in https://github.com/icecube/pisa/commit/4cb9172bd5a7b38c666f87f2bdeb92804a12d240 and used to have various effects as one can tell.

What to do with it? Make it, e.g., force compute always to call compute_function at least (no caching on identical parameter value hashes)?