Closed thehrh closed 1 month ago
Our possibly best documentation of the expected pipeline configuration format is the module's docstring, which contains several small mistakes and is outdated or incomplete in several places (see https://icecube.github.io/pisa/pisa.utils.html#module-pisa.utils.config_parser).
There also seems to be the same small bug in two methods of PISAConfigParser:
PISAConfigParser
_validate_value_types
RawConfigParser
ConfigParser
See https://github.com/icecube/pisa/issues/45
Our possibly best documentation of the expected pipeline configuration format is the module's docstring, which contains several small mistakes and is outdated or incomplete in several places (see https://icecube.github.io/pisa/pisa.utils.html#module-pisa.utils.config_parser).
There also seems to be the same small bug in two methods of
PISAConfigParser
:_validate_value_types
method ofRawConfigParser
ever returned something. At the time the code was introduced, https://github.com/icecube/pisa/blob/master/pisa/utils/config_parser.py#L1184 suggests it was based on https://pypi.org/project/configparser/3.5.0/._validate_value_types
does not return anything. In any case, the two methods are now identical to the same ones ofConfigParser
(https://github.com/python/cpython/blob/3.10/Lib/configparser.py#L1202 and https://github.com/python/cpython/blob/3.10/Lib/configparser.py#L1208).