icecube / pisa

Monte Carlo-based data analysis
http://icecube.github.io/pisa/
Apache License 2.0
19 stars 47 forks source link

Variable binning options #808

Open JanWeldert opened 4 weeks ago

JanWeldert commented 4 weeks ago

When defining a multidimensional binning we combine one dimensional binnings in a homogeneous grid. So if we for example bin our data in energy, coszen, and PID, we have to use the same energy and coszen binning for all PID bins. It was requested multiple times now to make this more flexible. A current hack is to use the detectors class to define different "detectors", one per PID bin (to use the example from before), and choose different energy and coszen binning for each of them. Note that for each detector you have to remove all events that don't fall in the respective PID bin.

LeanderFischer commented 4 weeks ago

Potential duplicate/overlap with #108, #158, #248, and #284.

JanWeldert commented 3 weeks ago

Right, #108 has the same idea. The others are mainly talking about making PID a binning dimension, which was already done. Might be possible to close some of them.

thehrh commented 2 days ago

@JanWeldert Should we add your comment on the possibility of using the Detectors class to #108 (which already contains a collection of implementation ideas) and then close this as duplicate? Or is the idea to implement a new service as per #108 too specific?

JanWeldert commented 1 day ago

Both ask for the option to have variable binning options, so we can close this one in favor of #108