search

icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

Possible function naming mismatch #117

Closed tomaskontrimas closed 1 year ago

tomaskontrimas commented 1 year ago

Function, comments and calls to every set_parameters in flux_models.py file should be renamed to set_params. https://github.com/icecube/skyllh/blob/d1da2b14c9c7744b597dded98405670d5529f978/skyllh/physics/flux_model.py#L1462-L1485 As they inherit from the MathFunction class: https://github.com/icecube/skyllh/blob/d1da2b14c9c7744b597dded98405670d5529f978/skyllh/core/math.py#L86