search

icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

Speed up initial analysis setup #129

Closed tomaskontrimas closed 1 year ago

tomaskontrimas commented 1 year ago

There is potential for ~53% speedup when creating analysis (detector signal yields).

image

We could sort data_sin_true_dec once, pass idxs to hist function and apply them to data_sin_true_dec, data_true_energy and weights.

https://github.com/icecube/skyllh/blob/a5c6185fa25dcdc46dca0084296282ba226a3542/skyllh/i3/detsigyield.py#L643 https://github.com/icecube/skyllh/blob/a5c6185fa25dcdc46dca0084296282ba226a3542/skyllh/i3/detsigyield.py#L613

chiarabellenghi commented 1 year ago

Can we close this issue? 😃

martwo commented 1 year ago

It will be closed automatically once I merge the parameter_handling branch!

tomaskontrimas commented 1 year ago

I've also tried to mark such issues with Fixed in SkyLLH v2 milestone