search

icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

`PDSignalGenerator` does not support multiple sources #140

Closed tomaskontrimas closed 1 year ago

tomaskontrimas commented 1 year ago

In case of multiple sources at different declinations in the same source hypothesis group, the cached self.effA object would be reused in signal generator, producing an incorrect result.

https://github.com/icecube/skyllh/blob/1e047b1f5557cd357fd9a40a904f305e6c72203b/skyllh/analyses/i3/publicdata_ps/signal_generator.py#L596-L601

Should raise an error if shg.source_list and shg_list lengths are not equal to 1.

chiarabellenghi commented 1 year ago

Actually, I would like to include support for the stacking analysis. I'll label this as WP

martwo commented 1 year ago

@chiarabellenghi Are you actively working in this? I would propose to add a check for the number of sources and raise an error if there is more than 1 source defined in the src_hypo_group_manager. When adapting the code for SkyLLH2 we can fix this then.