icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

Make `initialize_for_new_trial` method abstract and implement in derived classes with calls to `assert_is_valid_for_trial_data` of the PDF instances #145

Closed martwo closed 1 year ago

martwo commented 1 year ago

The initialize_for_new_trial method of the LLHRatio class should be mabe abstract and derived classes should implement it with calls to assert_is_valid_for_trial_data of PDF instances. https://github.com/icecube/skyllh/blob/dde775dd9e8dd896506a33ded7b63e522a547115/skyllh/core/llhratio.py#L109