Closed martwo closed 1 year ago
The initialize_for_new_trial method of the LLHRatio class should be mabe abstract and derived classes should implement it with calls to assert_is_valid_for_trial_data of PDF instances. https://github.com/icecube/skyllh/blob/dde775dd9e8dd896506a33ded7b63e522a547115/skyllh/core/llhratio.py#L109
initialize_for_new_trial
LLHRatio
assert_is_valid_for_trial_data
The
initialize_for_new_trial
method of theLLHRatio
class should be mabe abstract and derived classes should implement it with calls toassert_is_valid_for_trial_data
of PDF instances. https://github.com/icecube/skyllh/blob/dde775dd9e8dd896506a33ded7b63e522a547115/skyllh/core/llhratio.py#L109