icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

Rotation of MC events for signal event generation does not preserve relative declination difference between true and reco directions #187

Closed martwo closed 12 months ago

martwo commented 12 months ago

The rotation function https://github.com/icecube/skyllh/blob/130652f3724217c1ff9fa3080ba522ddbfb89608/skyllh/core/utils/coords.py#L6 does not preserve the relative declination difference between true and reco directions. This function is used in the class PointLikeSourceI3SignalGenerationMethod: https://github.com/icecube/skyllh/blob/130652f3724217c1ff9fa3080ba522ddbfb89608/skyllh/i3/signal_generation.py#L95