This seems unnecessary, as the detsigyield is a two dimensional spline of sin(dec) and fit parameter axes, and the change_source call only changes the source position in dec. Without rebuilding self._detsigyield_service, the change_source call takes miliseconds.
Have to make sure that dataset weights are recalculated correctly for analyses using multiple datasets.
Currently calling https://github.com/icecube/skyllh/blob/fce865d4cf65e6b35b735849624687792446ac8e/skyllh/core/analysis.py#L1715 from kdepdf_mcbg_single_ps analysis takes O(80seconds) as
change_sourcecalls https://github.com/icecube/skyllh/blob/fce865d4cf65e6b35b735849624687792446ac8e/skyllh/core/analysis.py#L703 which rebuildsself._detsigyield_service.This seems unnecessary, as the detsigyield is a two dimensional spline of sin(dec) and fit parameter axes, and the
change_sourcecall only changes the source position in dec. Without rebuildingself._detsigyield_service, thechange_sourcecall takes miliseconds.Have to make sure that dataset weights are recalculated correctly for analyses using multiple datasets.