icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

`ParameterGrid` enhancement #211

Open tomaskontrimas opened 9 months ago

tomaskontrimas commented 9 months ago

The ParameterGrid class could be merged with the IrregularParameterGrid, as there is no fundamental reason why it has to have a regular grid.

TODO:

martwo commented 9 months ago

Special care has to be taken when rounding floating point numbers. With a regular grid it is easier to make sure that all values are rounded to the specified decimal precision. I guess this can be achieved also with an irregular grid. But I would recommend to add excessive unit test coverage to ensure correct behavior.

If the rounding of a value is not consistent to fall on exact grid point values, the interpolation / PDF value lookup will fail, most probably for only a few values.