Open tomaskontrimas opened 9 months ago
Special care has to be taken when rounding floating point numbers. With a regular grid it is easier to make sure that all values are rounded to the specified decimal precision. I guess this can be achieved also with an irregular grid. But I would recommend to add excessive unit test coverage to ensure correct behavior.
If the rounding of a value is not consistent to fall on exact grid point values, the interpolation / PDF value lookup will fail, most probably for only a few values.
The
ParameterGrid
class could be merged with theIrregularParameterGrid
, as there is no fundamental reason why it has to have a regular grid.TODO:
Parabola1DGridManifoldInterpolationMethod
interpolation to support an irregular grid: https://github.com/icecube/skyllh/blob/6c3e66fefebd521c82ccdb67ebd3574ef401fd10/skyllh/core/interpolate.py#L672-L673