search

icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

Fix 219 #220

Closed tomaskontrimas closed 4 months ago

tomaskontrimas commented 4 months ago

Apply mask to events_meta as we initially draw events from all datasets and signal_event_post_sampling_processing expects the same shape of events_meta and events arrays.

Fixes #219 issue. It does not change the signal injection behaviour when events fall within valid event field ranges (e.g. declination range after events rotation). Trials would fail when generating signal for analyses with multi datasets and/or multi source hypothesis groups.

It follows the same logic as in the initial signal events drawing in L886-897: https://github.com/icecube/skyllh/blob/f8e4ea6eda5987c0df2445259982e937155e0490/skyllh/core/signal_generator.py#L886-L897

tomaskontrimas commented 4 months ago

Oops, I guess analysis unit tests https://github.com/icecube/i3skyllh/actions/runs/8241075808 fail due to the livetime calculation change before the v24.1.0 release (see the test on master/v24.1.0 https://github.com/icecube/i3skyllh/actions/runs/8241246057/job/22538113710).

Let's fix them first, before merging this fix.

martwo commented 4 months ago

Good catch! Thanks for fixing this.