search

icecube / skyllh

https://icecube.github.io/skyllh/
GNU General Public License v3.0
11 stars 5 forks source link

Fix #223 #224

Closed juanma-cano-vila closed 7 months ago

juanma-cano-vila commented 7 months ago

The proposed fix was implemented. Another possible solution, as poited by Chiara, would be just to add an else statement.

if poisson: 
     mean = rss.random.poisson( 
         float_cast( 
             mean, 
             'The  'mean' argument must be castable to type of float!')) 

else: 
    n_events = int_cast( 
         mean, 
         'The 'mean' argument must be castable to type of int!')

I choose the first solution for consistency with the one already implemented in the analog class MCMultiDatasetSignalGenerator.

martwo commented 7 months ago

Looking good