search

icecube / skymap_scanner

A distributed system that performs a likelihood scan of event directions for IceCube real-time alerts using CPU cluster(s) and queue-based message passing.
5 stars 2 forks source link

Clean up of symlinks #13

Closed mlincett closed 2 years ago

mlincett commented 2 years ago

Several files in resources/scripts are symlinks to python. This likely requires a cleanup.

ric-evans commented 2 years ago

This is similar (but different) to https://github.com/icecube/skymap_scanner/issues/5

mlincett commented 2 years ago

@ric-evans is this blocking for you in some way? I have started a review/cleanup of the code so I have a better idea of what should go where, however it may take some time before I get to the point of tidying up the symlinks.

ric-evans commented 2 years ago

Yes, and no. For the time being, symlinks are better than duplicate files. If we could replace old versions of .py files with symlinks to the newer version (#5), this could go a long way in understanding what should go where.

My ultimate goal is to shake up the entire directory tree (this would be a follow-up issue/PR). I'd like four directories:

What I'm seeing that's concerning currently is there are scripts in python and modules in resources/scripts, this is something that I'd like to fix.

dsschult commented 2 years ago

Something to keep in mind is whether this is an "icetray" project, or a regular python project. They have different formats, with what @ric-evans is proposing is the python project format.

ric-evans commented 2 years ago

Something to keep in mind is whether this is an "icetray" project, or a regular python project. They have different formats, with what @ric-evans is proposing is the python project format.

That's true. There's a large similarity in either format: let's reduce the number of directories with python files.