icecube / skymap_scanner

A distributed system that performs a likelihood scan of event directions for IceCube real-time alerts using CPU cluster(s) and queue-based message passing.
5 stars 2 forks source link

`notify_alert` definition in global scope of `alert_v2_listener.py` #15

Closed mlincett closed 2 years ago

mlincett commented 2 years ago

This code segment in alert_v2_listener.py defines a global notify_alert message. The code seems outdated and apparently refers to old (undocumented) slack channel IDs.

https://github.com/icecube/skymap_scanner/blob/2aec95f9c740a38f15c9f3ffe085d89faa437dd5/resources/scripts/alert_v2_listener.py#L56-L64

The variable is later redefined in the main code section so it seems like the segment could be safely removed.

(More in general we should move away from global variables and the listener main code should be probably enveloped in its own function).

mlincett commented 2 years ago

Took care of it in abb15ad