search

icecube / skymap_scanner

A distributed system that performs a likelihood scan of event directions for IceCube real-time alerts using CPU cluster(s) and queue-based message passing.
5 stars 2 forks source link

Migrate Files to `skyreader` & `skywriter` [minor] #178

Closed ric-evans closed 1 year ago

ric-evans commented 1 year ago

closes #121

ric-evans commented 1 year ago

@tianluyuan we're using metadata with the numpy dtype. Mypy is complaining about this -- I added an in-line ignore since it seems to work. However, I did come across https://numpy.org/devdocs/reference/generated/numpy.dtype.metadata.html

Although used in certain projects, this feature was long undocumented and is not well supported. Some aspects of metadata propagation are expected to change in the future.

It may be worth thinking about

tianluyuan commented 1 year ago

One thing that could be nice is to preserve commit history in the move. It's not so difficult but not sure how you feel about going through the files.

ric-evans commented 1 year ago

One thing that could be nice is to preserve commit history in the move. It's not so difficult but not sure how you feel about going through the files.

I'll look into this

ric-evans commented 1 year ago

Looks good! Should this be a major version bump?

There are no breaking changes, so a minor bump is fine.