search

icecube / skymap_scanner

A distributed system that performs a likelihood scan of event directions for IceCube real-time alerts using CPU cluster(s) and queue-based message passing.
5 stars 2 forks source link

IceTray project or python package #19

Closed mlincett closed 2 years ago

mlincett commented 2 years ago

Following up on issue #13 and the discussion on Slack, a decision should be made about whether maintaining the skymap_scanner as a python package or as an IceTray project. In the second case, it could be integrated into realtime_tools.

@dsschult suggested to split the project between a pure-python server side an IceTray client handling the actual LLH scan. This could simplify the implementation of CI testing.

I am opening this issue for further discussion.

ric-evans commented 2 years ago

I strongly advocate separating skymap_sanner as its own python package. I've run into the scenario @dsschult mentioned about CI testing. It's much simpler adding icetray (icecube) as a resource, then building it with skymap_scanner included as a project.

ric-evans commented 2 years ago

CI testing is our best bet at measuring how this all will function once it's cloud-bound / in other strange new places

ric-evans commented 2 years ago

Also, cloud_tools does exactly this. They use skymap_scanner-type imports (technically pulsar_icetray), not icecube.skymap_scanner imports. So making this a python package will help in reconciling the two

kjmeagher commented 2 years ago

I think making this a python package is a good idea as well. There seems to be a general trend of people preferring code which is independent of IceTray and this code seems to be only loosely coupled with IceTray